- 
                Notifications
    
You must be signed in to change notification settings  - Fork 148
 
Feat : Added support for core set frame list dumping and computed state dumping and loading #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feat : Added support for core set frame list dumping and computed state dumping and loading #1697
Conversation
…d loading Signed-off-by: AdityaSinghDevs <[email protected]>
| 
           Hi @djdameln , @wonjuleee , @zhiltsov-max  | 
    
| 
           Hey,  | 
    
          
 Hi @AdityaSinghDevs thanks for your contribution! We appreciate you patience, and started looking if we can accept your PR. Expect updates in the nearest future  | 
    
| self.algorithm_specific = kwargs | ||
| self.kept_item_id = None | ||
| self._initialized = False | ||
| self.save_media= save_media | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space before = is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
I'll resolve it, can you tell me if there are any other changes needed? I can compile the changes and push them all at once.
Thankyou
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side, that's it. Perhaps @djdameln has something to add
Also, it'd be extremely convenient for us if you provide as small video dataset to check if the plugin is not broken after the refactoring
Summary
Summary of changes made to NDR transform plugin:
Added functionality to:
Support core set frame list dumping via new CLI options and methods:
Enable computed state handling for multiple input sources:
Added corresponding CLI arguments:
These changes allow efficient processing of large video datasets by:
Resolves #140
How to test
Process dataset with multiple video sources using:
python ndr.py --save-core-set core_frames.list --save-deduplicated dedup.list output_dirVerify outputs:
Test with large datasets:
Checklist
License
Feel free to contact the maintainers if that's a concern.